Important Dates

Latest Posts

Topic: Move Widelands to GitHub

GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3159
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2020-03-15, 20:14

Tada-ching! https://code.launchpad.net/~widelands-dev/+recipe/widelands-daily

The daily PPA is back face-smile.png

Thanks to Nordfriese for the mirroring face-smile.png


Busy indexing nil values

Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 1496
Ranking
One Elder of Players
Location: North of Germany
Posted at: 2020-03-16, 14:13

Very nice, thanks!

Unfortunately it didn't work yet, starting Widelands not working:

"Caught exception (of type '13ImageNotFound') in outermost handler! The exception said: [/build/widelands-F_NG84/widelands-20-ppa0-bzr9213/src/graphic/image_io.h:34] Image not found: images/logos/wl-ico-128.png

This should not happen. Please file a bug report on version bzr9213-202003151758(Release)."


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3159
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2020-03-17, 08:18

Thanks for reporting. Should be fixed now - new builds will be ready in 1-2 hours.


Busy indexing nil values

Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 1496
Ranking
One Elder of Players
Location: North of Germany
Posted at: 2020-03-17, 13:16

GunChleoc wrote:

Thanks for reporting. Should be fixed now - new builds will be ready in 1-2 hours.

You're welcome

It works! Excellent!


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3159
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2020-03-17, 16:37

Perfect face-smile.png


Busy indexing nil values

Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07
Posts: 706
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: Today 22:58

I've been thinking a bit about our automated code quality checks on travis. When there are many PRs open it can take many many hours until one's latest commit finally starts running on travis, only to see it fail due to some annoying typo in an RST or something like that, and then it takes again many many hours until the typo-fixing commit starts being built, and so on.
So I have considered moving the tests of the first build stage to another github action. (Such an action could be made required for PRs like the travis build, so this would still be enforced for merging.) I have a functional branch here: https://github.com/Noordfrees/widelands/pull/4

Unfortunately this does not integrate with the formatting action. GitHub says

When you use the repository's GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur. For more information, see "Authenticating with the GITHUB_TOKEN."

If you would like to trigger a workflow from a workflow run, you can trigger the event using a personal access token. You'll need to create a personal access token and store it as a secret in your repository.

https://help.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token

GitHub recommends creating a personal access token (PAT) as a secret for the action to use. For branches in the base repo (e.g. PRs from widelands:branchname to widelands:master) we could simply use bunnybot's PAT. But for branches in forks (username:branchname to widelands:master) this would make it necessary for all devs to create a PAT with write access and add it as a secret to their fork to allow our actions to use it, which probably not everybody would like.
(In the absence of such a token we could fallback to GITHUB_TOKEN of course so the formatting will work anyway, but then the checksuite wouldn't run on the formatting bot's commit.)

Opinions?


Top Quote