Topic: Improve road-system concerning jams
ypopezios Topic Opener |
Posted at: 2018-05-31, 18:54
Note: This thread adopts a useful practice to improve its readability: The first/opening post will get regularly updated from later posts with every important information, so as to keep everything important in one place. This thread is a parallel to: Congestion Competition and a solution to: ai roads getting jammed a lot The requirements are these:
This is not a perfect final solution, it is merely a considerable improvement, an early step to the right direction, of a bigger effort to improve Widelands' road-system and overall performance of big maps. After much analysis and calculations, number 6 has been found to be the critical one, and it all comes down to the following algorithm, which checks the number, type and destination of wares stored on a flag, waiting to be carried by someone:
UPDATE: An implementation of that got merged in the official installation for build 20. Edited: 2018-08-09, 10:58
Top Quote |
ypopezios Topic Opener |
Posted at: 2018-06-26, 17:14
The first implementation of a hopefully congestion-free version of Widelands is available on the opening post. All players interested in demanding maps (big and/or narrow) are encouraged to try it and, other than testing whether congestion will occur, to also pay close attention to the behaviour of the carriers, whether it is fully expectable. The changes happen to also affect the promotion of roads, but this is something addressed in a different fix. Top Quote |
GunChleoc |
Posted at: 2018-07-06, 21:48
I just did a round of code reviews on both of your branches - are you happy with the state of the road promotion one for merging? Busy indexing nil values Top Quote |
ypopezios Topic Opener |
Posted at: 2018-07-07, 03:02
@GunChleoc Those two branches have some target functions in common, so I'd be happy to see one of them merged, for the other to work with cleaner code. Top Quote |
GunChleoc |
Posted at: 2018-07-07, 09:50
OK, I have triggered a merge for road_promotions, since it has been tested. Thanks for your work on this! Edited: 2018-07-07, 09:51
Busy indexing nil values Top Quote |
ypopezios Topic Opener |
Posted at: 2018-07-07, 10:31
Just to note that the said merge doesn't close the present topic. Actually, this thread is still in its first days. I will have to review the code of its branch, as it cannot incorporate directly the changes of road_promotions. I will report back here of course. Top Quote |
ypopezios Topic Opener |
Posted at: 2018-07-29, 22:37
This is again working and ready for testing, this time including the road-promotion fix. Use the links at the end of the opening post to get windows versions. Top Quote |
ypopezios Topic Opener |
Posted at: 2018-08-09, 10:50
The proposed (imperfect) solution got merged, so further testing can take place with trunk versions. Top Quote |