Topic: Rework Atlantean Crystal Mine

GunChleoc wrote:

WorldSavior wrote:

Are you sure? I thought that the lines with "mine" will cancel the program, not the whole cycle of programs. Canceling a program usually doesn't cancel the cycle, but the next program will run...

That's true.

Okay, that's surprising me.... And I still don't believe it:

I made a little experiment now; build a crystal mine in an area where it couldn't find stone resources and let it run, controlling that it has never a resource shortage and that all economy settings were always much higher than stock. (in build 19)

My observation: The crystal mines found many stones and diamonds, but not a single quartz. That's almost a prove for my thesis

Since the first program in the list doesn't produce any diamonds whatsoever, this actually disproves your thesis that only the first program is executed.

That's not my thesis, it's teppo's

WorldSavior wrote:

Otherwise, trainingsites would have a big problem...

Oops, I forgot trainingsites. You're right about them. But they are working different to productionssites, I guess...

They are productionsites with an extra soldiers tab. So, they work exactly the same

That's not what I observed

For example, if an atlantean weapon smithy gets full supply and no limits by economy settings, it will work according to the pattern 1 2 3 4 5 1 2 3 4 5 1 and so on.

But if a dungeon gets full supply and only three rookies go in there, it will work according to the pattern 1 1 1 2 2 2 3 3 3 4 and so on.

WorldSavior wrote:

I think I understand why. Let's take a look at a part of the quartz program:

"consume=smoked_fish,smoked_meat:2 atlanteans_bread:2",

        "animate=working 20000",

        "mine=stones 4 100 5 2",

        "produce=granite:2",

        "animate=working 20000",

        "mine=stones 4 100 5 2",

        "produce=granite quartz",

At the line with "mine", the probability that the next line will follow is 5%. But then it produces 2 granite, doesn't it? After this, there is another line with "mine", so the probability that the line with "produce quartz" will be reached is (5%)².

Then the solution would be to reorder the produce statements to have the precious stones on top.

This would probably achieve that more quartz would be find indeed.

And I thought about another solution which wouldn't contradict yours: What if the probabilities in the "mine"-lines get increased so much that they make sure that the efficiency of the mines will be 5% indeed?

WorldSavior wrote:

GunChleoc wrote:

I'd have to dig deeper into the code to try to understand when workers gain experience, but when mining and the mining fails, there is still a random chance that they will gain experience anyway.

Isn't it also another bug that a miner doesn't get experience if he finds nothing?

I don't really like how this is hard-coded.

Me neither...

Wanted to save the world, then I got widetracked

Top

Quote

GunChleoc wrote:

Found the program selection for the trainingsites:

~~~~ /* * Find and start the next training program. * * Prioritize such that if UpgradeA.prio is twice UpgradeB.prio, then * start_upgrade will be called twice as often for UpgradeA. * If all priorities are zero, nothing will happen. / void TrainingSite::find_and_start_next_program(Game& game) { ~~~~

And the production site has: ~~~~

void ProductionSite::find_and_start_next_program(Game& game) { program_start(game, "work"); } ~~~~ So, you're right, it's indeed different. There's a lot more code to dig through though before I understand what's really happening, because it also depends on when this function is called and what happens then...

I don't understand exactly everything of trainingsites neither, but probably most things...

Wanted to save the world, then I got widetracked

Top

Quote

Ok I found out the reason for this behaviour:

Mines which produce Building materials have a minimum amount of 2 hardcoded in defaultai.cc. Currently these are empire_marble_mines and atlanteans_crystal_mines.
For the empire this is never a problem because a basic mine just needs one miner. In the contrary the empire need for marble is much higher than the atlantean need for diamond and quartz, so they really could live well with two marble_mines.
Different story for the Atlanteans they would happily live with only one crystal_mine for a long game time, but really miss the 3 miners in the second_crystal_mine.

So currently I see 3 solutions:
a) Increase number of miners in atlanteans starting conditions
b) decrease workers needed for atlanteans crystal_mine
c) handle these types of mines as any other mines i.e. all mines have a minimum of only one.

I would vote for option c) as it should have minimum impact on empire (they should build a second mine as soon as their marble supply drops) and gives the atlanteans AI a much better chance in the early game.

Top

Quote

I agree with c) - we shouldn't change game balance if it can be fixed in the AI. The enhancement is a valid point, you could check for

tribe_->get_building_descr(building_index)->enhancement() != INVALID_INDEX

instead and let the genetic algorithm take care of the rest.

Busy indexing nil values

Top

Quote

If your fix will not work for what reason ever, you could also think about giving the AI a limit for crystal mines of 1. I mean, for what does an AI need several crystal mines anyway? In most situations it's perfect to build less than 2.

By the way, the crystal mine should be build in almost every match after the three other types of mines...

Let me guess: It would be too complicated to code that the AI can kick out some miners if the tool-economy is not complete yet?

I've observed another idiotic behaviour of the AI. If a mine is not occupied yet, the AI will always dismantle it after a while.

Wanted to save the world, then I got widetracked

Top

Quote