Topic: savegane backward compatibility?
jmoerschbach Topic Opener |
Posted at: 2019-09-26, 20:47
Hi, after filing in my very first bug on github, I just registered on the forum since I like to join your community and hopefully, I can contribute in some ways in near future Before I file the next bug, I thought maybe I'll ask before... I've started playing campaigns with official build 20 release. When I load a savegame (first atlanteans mission) in self-compiled trunk version, I'll get an error saying buildingdata: building 1818519809: not found So I guess my savegame from b20 is not compatible with trunk version. Is this accepted/intentional or am I doing something wrong? If it is considered a bug, I'll file an issue with savegame, screenshot etc... Regards, Jonas Top Quote |
einstein13 |
Posted at: 2019-09-27, 08:44
Hi and welcome to the forum! Save games are intended to be version-specific. Usually you can open the file with trunk version of Widelands +/- a few commits. The same is when you try to play a multiplayer game. If you try to play a game with someone who doesn't have the same Widelands version, the game can desynchronises pretty soon (or you will not able to connect). As far as I know only maps are designed to have backward compatibility. But even this is broken somewhere in the past: you can download very old maps from "The Game -> Maps" section and not be able to open them with the editor. einstein13 |
GunChleoc |
Posted at: 2019-09-27, 08:54
We are trying to keep savegame compatibility too as much as we can. There's a change that broke it and we haven't had time to track down the commit that broke it yet. Busy indexing nil values Top Quote |
WorldSavior |
Posted at: 2019-09-27, 16:44
I disagree. Usually "few commits" is not true but "a lot of commits" - breaking of savegame compability is rather rare.
I see it between 9182 and 9203. Wanted to save the world, then I got widetracked Top Quote |
GunChleoc |
Posted at: 2019-09-27, 17:21
Thanks for narrowing it down Busy indexing nil values Top Quote |
niektory |
Posted at: 2019-09-27, 17:48
You mean the one that made Build 20 savegames unloadable with later versions? Top Quote |
GunChleoc |
Posted at: 2019-09-27, 18:18
Looks like the culprit is this one: https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/9107 It does contain compatibility code, but it contains a mistake that is so duh that I'll push a fix directly to master. The things one does not see during code review... And welcome aboard! Edited: 2019-09-27, 18:27
Busy indexing nil values Top Quote |
niektory |
Posted at: 2019-09-27, 20:30
There's at least one more problem with loading Build 20 saves. Trying to load the attached savegame results in the following error:
Likely related to the following commits: 777771e9ed Renamed thatch reed to reed. c7e8e09267 Fix savegame compatibility for reed, buildings, players view and economy requests. Top Quote |
GunChleoc |
Posted at: 2019-09-28, 00:08
Confirmed. I'm a bit pressed for time right now, could you please open an issue on GitHub? Thanks! Busy indexing nil values Top Quote |
niektory |
Posted at: 2019-09-28, 01:20
Issue: Can't load Build 20 save: unknown ware type "thatch_reed" #3529 Top Quote |