Topic: print statements and other files
kaputtnik Topic Opener |
Posted at: 2024-01-23, 16:02
My addons are ready but i wait for the ui-plugins3 branch to be merged before i upload them. The last questions i have:
Fight simulator for Widelands: |
Nordfriese |
Posted at: 2024-01-23, 18:04
Merged a minute ago
IMO it is cleaner to remove all such statements, but for add-ons, best coding practices are entirely optional
Depends on the size and how important sharing the sources is to you, IMO. If they're just a few kB it doesn't hurt to include them. If you have really big source assets, they shouldn't be bundled with the add-on and if you want to share them I'd recommend uploading them to a repo on CB/GH or elsewhere.
Ouch. TBH I had not thought of add-on developers being so diligent about version control… Maybe I should add something to prevent this: a hardcoded exclusion list of common VCS dirs like ".git" and ".bzr", or how about a .gitignore-style ".wlignore" that allows you to exclude arbitrary files and directories from uploading? Top Quote |
tothxa |
Posted at: 2024-01-23, 19:22
+1
+1 Though wouldn't globbing be hard? And without globbing, it would be often uncomfortable to use. Top Quote |
kaputtnik Topic Opener |
Posted at: 2024-01-23, 19:41
Thanks Hm, the print statements... it is just interesting how memory consumption grows and shrinks after a cellectgarbage. Especially the analyse_map add-on needs a lot of memory if you analyse a very, very big map as a whole. In one of the first versions it was about 10GB... now it's "only" 1,7 GB. I think i'll leave them in the analyse_map add-on and remove them in the height_tools add-on which is not that memory hungry. The xcf-files have just 36kb, i'll keep them in the add-on. Git is just a nice helper if you have a working solution but you want to make some refactoring or add new stuff to the UI... . Will create a new folder then. And for uploading i think just ignoring hidden files would be sufficient, imho. Fight simulator for Widelands: |
kaputtnik Topic Opener |
Posted at: 2024-01-24, 09:17
Easier said than done, because you also have to change all the
-> https://codeberg.org/wl/widelands/issues/4689 Fight simulator for Widelands: |