Topic: Geologist control
hessenfarmer
Joined:
2014-12-11, 23:16 UTC+1.0
Posts: 2828  One Elder of Players Location: Bavaria |
Posted at:
2020-10-21, 13:32 UTC+2.0
+1 this seems to be the best solution imho as it would prefer ores over water. 
Top
Quote
|
Nordfriese
Joined:
2017-01-17, 18:07 UTC+1.0
Posts: 2139 OS: Debian Testing Version: Latest master One Elder of Players Location: 0x55555d3a34c0 |
Posted at:
2020-10-21, 15:32 UTC+2.0
https://github.com/widelands/widelands/pull/4391
Top
Quote
|
kaputtnik
Joined:
2013-02-18, 20:48 UTC+1.0
Posts: 2658 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at:
2020-10-21, 19:10 UTC+2.0
What if the player wants to look for water at such a flag? If the water is maybe necessary in the future:
Some behavior of the game is not logical. Why should a geologist should go to find only ores, although some non mountain terrain in his vicinity?
Top
Quote
|
|
Nordfriese
Joined:
2017-01-17, 18:07 UTC+1.0
Posts: 2139 OS: Debian Testing Version: Latest master One Elder of Players Location: 0x55555d3a34c0 |
Posted at:
2020-10-21, 19:44 UTC+2.0
Place a flag just beneath the mountain's edge and send the geologist there. After all there is no water in the mountains so any place where you might want to find water has to have at least one small plot (for the well) where you can place the flag to send the geologist to. And the geologist may also find water on the edge between mountain and meadow. Those edge tiles are also considered mountain but can hold both water or ores.
To me this is logical: The geologist doesn't look for resources because he feels like a walk, but because you gave him an explicit order. Sending a geologist to a flag near mountain is like telling him "Go and find me resources in those mountains!". Sending a geologist to a flag in the valley is like telling him "Go and find me resources in this valley!". So the geologist obediently restricts his search to the indicated area – mountain or valley. How about adjusting the tooltip in the fieldaction window to tell the player whether the geologist would look for ores or water from this flag?
Top
Quote
|
|
hessenfarmer
Joined:
2014-12-11, 23:16 UTC+1.0
Posts: 2828 One Elder of Players Location: Bavaria |
Posted at:
2020-10-21, 19:51 UTC+2.0
if he wants to look for water he could use the next flag in this direction. Normally mountains are less big and less available then water. That is why I would vote for having the new behavior as sometimes it is difficult to search for ores in a small mountain. (e.g. in empire 3 there is a small mining plot on 1 of the islands where there is some gold which can't be searched as you need to place the flag exactly on the spot where the gold is to search for and all other spots are empty.
Top
Quote
|
|
kaputtnik
Joined:
2013-02-18, 20:48 UTC+1.0
Posts: 2658 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at:
2020-10-21, 23:19 UTC+2.0
I do not see any reason why the geologist should be forced "Go and find me resources in those mountains!" just because the flag which demands the geologist is adjacent to a mountain. Whereas i find it logical to force him to "Go and find me all resources in this valley!", wherever the flag was set.
Well, with my suggestion you haven't bother. Just place a flag near the mountains and send a geologist an he will also examine the small mountain area. In addition the flag may not reduce building spaces for mines.
Top
Quote
|
GunChleoc
Joined:
2013-10-07, 15:56 UTC+2.0
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at:
2020-10-22, 08:14 UTC+2.0
The problem with that suggestion is that the geologist will pick a completely random spot within his search area and he won't cover all the spots. So, there's a good chance he won't though that small mountain patch at all and you will have to send another one. The current behavior depends on which edge of the mountain you place the flag on, because the check depends on 3 of the 6 triangles. This is a non-symmetric implementation detail that can't be clear to the player in any shape or form. Busy indexing nil values
Top
Quote
|
|
kaputtnik
Joined:
2013-02-18, 20:48 UTC+1.0
Posts: 2658 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at:
2020-10-22, 18:11 UTC+2.0
Some players send more than one geologist anyway Combine place flag and send geologist would help then.
Top
Quote
|
mxb2001
Topic Opener
Joined:
2019-05-20, 18:49 UTC+2.0
Posts: 363 OS: Linux Version: 1.2  Tribe Member Location: The land of the thirsty spider |
Posted at:
2020-10-23, 03:27 UTC+2.0
I tried sending a geo to a edge with mountain on 3 or more sides and they still looked for water. How do you make them work? --
Top
Quote
|
|
GunChleoc
Joined:
2013-10-07, 15:56 UTC+2.0
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at:
2020-10-23, 06:47 UTC+2.0
I'm still in favor of merging the proposed change. The other issues will take longer to address, and it would already be an improvement to make this change. https://github.com/widelands/widelands/pull/4391
Edited:
2020-10-23, 06:48 UTC+2.0
Busy indexing nil values
Top
Quote
|
So the geologist should keep the ability to search for water