Polls

Best Build 21 Screenshot

Log in to vote!

Latest Posts

Topic: Game suddenly very slow

Nordfriese
Avatar
Joined: 2017-01-17, 18:07
Posts: 933
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-07-02, 18:57

The underlying issue is known: https://github.com/widelands/widelands/issues/3671

But this is not good, not good at all…
Can someone please test whether b20 savegames can still be loaded with master? If not we need to fix this very very quickly


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 1419
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2020-07-02, 19:09

the culprit is https://github.com/widelands/widelands/pull/3933
and savegames containing barbarians, frisians and atlanteans will fail therefore.

Sorry I didn't think about savegame compatibility.

My idea for a quick fix will be to use the on failure fail parameter. I need to test this though.


Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07
Posts: 933
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-07-02, 19:11

I opened a pull request to just start the main program when this happens: https://github.com/widelands/widelands/pull/3960


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 1419
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2020-07-02, 20:14

Nordfriese wrote:

I opened a pull request to just start the main program when this happens: https://github.com/widelands/widelands/pull/3960

Compiled and tested it. works as desired.
sorry for the trouble


Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3199
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2020-07-03, 08:06

Handling savegame compatibility while loading the game is better performance rather than doing it continuously throughout the game.

Could you please test your savegame with https://github.com/widelands/widelands/pull/3961

Thanks!


Busy indexing nil values

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 134
Ranking
At home in WL-forums
Location: Poland
Posted at: 2020-07-04, 03:05

I checked some b20 savegames and they load fine except for the scenario Surprise, Surprise! which throws this error:

Fatal exception: [../src/scripting/lua_errors.cc:22] [../src/scripting/lua_errors.cc:22] empire_brewery2: Error in productionsite program work: Error reading line 'playsound=sound/empire beerbubble 180': Usage: playsound=<sound_dir/sound_name> [priority]
stack traceback:
    [string "scripting/tribes/brewery2.lua"]:3: in main chunk
    [C]: in global 'include'
    [string "scripting/tribes/init.lua"]:11: in local 'func'
    [string "scripting/mapobjects.lua"]:20: in global 'print_loading_message'
    [string "scripting/tribes/init.lua"]:7: in main chunk

Attachment: 154.wgf (1.4 MB)

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 134
Ranking
At home in WL-forums
Location: Poland
Posted at: 2020-07-04, 03:07

A save from the scenario The Great Stormflood loads but on mission completion shows this error:

Error in Lua Coroutine
[../src/scripting/lua_errors.cc:22] [string "scripting/mission_thread.lua"]:458: attempt to call a nil value (method 'reveal_scenario')

Tested in r24654[c8ca093@master] (Release)


Attachment: 106.wgf (936.8 KB)

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3199
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2020-07-04, 07:21

Thanks! I'm on it.


Busy indexing nil values

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 134
Ranking
At home in WL-forums
Location: Poland
Posted at: 2020-07-04, 07:44

And on the topic of game being slow, the performance does seem to have degraded noticeably since build 20.


Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3199
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2020-07-04, 07:50

Pull request is up: https://github.com/widelands/widelands/pull/3963


Busy indexing nil values

Top Quote