Topic: Spaced percent sign
|
MiroslavR Topic Opener
Joined: 2010-10-16, 17:56
Posts: 35  Pry about Widelands Location: Slovakia |
Posted at: 2015-08-08, 16:19
I suggest to make the productivity labels (both in the building statistics window and production site overlay) translateable. The reason is that percent signs may be spaced in some languages (including the one I'm translating into). However, I've noticed that adding a space in the building statistics window (by changing the source code) seems to break the layout by introducing an unnecessary scrollbar like so:
Top
Quote
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317  One Elder of Players Location: RenderedRect |
Posted at: 2015-08-08, 16:36
We cannot handle spaces in the production site window yet, there isn't enough room. I plan to revisit these labels once we finally have the new font renderer. Busy indexing nil values
Top
Quote
|
|
MiroslavR Topic Opener
Joined: 2010-10-16, 17:56
Posts: 35 Pry about Widelands Location: Slovakia |
Posted at: 2015-08-08, 20:48
Interestingly enough, the text actually does fit if the scrollbar's width is omitted in the effective width calculation.
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at: 2015-08-08, 21:14
I know - I'm not up to fixing that though at the moment. It's a bit too low-level for me. I had to use Multilinetextarea, because Textarea doesn't have the colours. I think the colours are more important right now than the spaced percent sign or centering the labels. Busy indexing nil values
Top
Quote
|
|
MiroslavR Topic Opener
Joined: 2010-10-16, 17:56
Posts: 35 Pry about Widelands Location: Slovakia |
Posted at: 2015-08-09, 12:07
You can already do that with Textareas. Or am I missing something here?
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at: 2015-08-09, 22:58
I had problems with them at the time when I worked on the branch. I might have missed something though. Busy indexing nil values
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at: 2015-08-12, 11:16
Fixed it: https://code.launchpad.net/~widelands-dev/widelands/bug-1463829/+merge/267779 The problem was that some colors where hex and some RGB. I had already fixed it and then forgot that this was the original problem Busy indexing nil values
Top
Quote
|
|
MiroslavR Topic Opener
Joined: 2010-10-16, 17:56
Posts: 35 Pry about Widelands Location: Slovakia |
Posted at: 2015-08-12, 16:23
Nice, thanks! Could you also make this string translatable: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/productionsite.cc#L320 ?
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at: 2015-09-03, 15:03
Fix is in trunk. I'll make the string translatable in the string-fixes branch. Busy indexing nil values
Top
Quote
|
