Topic: main roads becoming normal again

ypopezios wrote:

GunChleoc wrote:

I just had an idea: if you used Bazaar to download the code (no Launchpad login required), you could use it to generate diff files. This would make it a lot easier for Tibor to apply your changes.

If I find out that I ask often for many changes, I will definitely promote my computer into a Widelands development machine.

that was not what Tibor and GunChleoc were asking for, to ease up Tibors work. They just ask to download only the relevant source files from launchpad via the single file download interface provided there (if you browse the code) navigate to the relevant folder and click the tiny download icon on the right) then use an appropriate editor to change the code and either send tibor a compressed version of the new file or a diff which should be obtainable from the editor.
From my perspective this sounds more efficient as Tibor doesn't need to retype the code provided here in the forum. Retyping code is not really the most error free and by far not the most interesting work to do. For you it is just very little additional effort once you have downloaded the first issue of the file.
Therefore I think their request is very reasonable already and there is no need to wait for more requests.

Top

Quote

I take it as my investment (of my time) in ypopezios and widelands. Anyway the fix will soon be done and than ypopezios will see if he wants to stay and contribute to widelands

Top

Quote

Tibor wrote:

the fix will soon be done

We are very close indeed. But I see no activity in AppVeyor since three days. Is this normal?

Meanwhile, a minor alteration in file economy/road.cc, merely to clear-up that whole coins get charged in whole seconds:

// line 563
last_wallet_charge_ = game.get_gametime() / 1000;

// lines 570-578
const uint32_t gamesecs = game.get_gametime() / 1000;
assert(last_wallet_charge_ <= gamesecs);
const uint8_t carriers_count = (carrier_slots_[1].carrier == nullptr) ? 1 : 2;

log ("wallet: %d, carriers: %d, gamesecs: %d, last_charge: %d, steps: %lu\n",
     wallet_, carriers_count, gamesecs, last_wallet_charge_, path_.get_nsteps());

wallet_ -= carriers_count * (gamesecs - last_wallet_charge_);
last_wallet_charge_ = gamesecs;

Top

Quote

Tibor wrote:

I dont track what is doing on there. Do you mean there are no builds from newest revision I pushed there?

I saw the new version on launchpad, but I see no builds on AppVeyor. Which means no tests on my part.

Top

Quote