Topic: New experimental tribe: Europeans

Forums » Player Forums » Add-Ons » New experimental tribe: Europeans
MarkMcWire
Avatar
Topic Opener
Joined: 2017-02-08, 21:06 UTC+1.0
Posts: 394
Ranking
Tribe Member
Location: Eisenach, Germany
Posted at: 2025-04-11, 11:20 UTC+2.0

I had included a feature that allowed you to expand the advanced quarry into a basic small farm once all the stones were mined. The problem is that the small farm itself has a enhancement, which gives you four different work areas.

I've removed that feature with version 2.4.1.1.

Edited: 2025-04-11, 11:22 UTC+2.0

My widelands addons: https://drive.google.com/file/d/1jopANlODo41T2reHJ0zaCOMYxq_rxXP-/view?usp=sharing

Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2158
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2025-04-13, 21:56 UTC+2.0

PR: https://codeberg.org/wl/widelands/pulls/5054

My proposed patch will show a well-behaved error message during tribe loading, instead of risking an application crash.

Unfortunately truly supporting more than 3 workareas would be hard…

Edited: 2025-04-13, 21:57 UTC+2.0
Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2158
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: Yesterday 19:58 UTC+2.0

In review of the newly uploaded europeans_all.wad I saw that a lot of units use the "tribes" textdomain which will not work. They should all use the "europeans_all.wad" textdomain.

With regard to https://codeberg.org/wl/wl_addons_server/issues/98 , please confirm again which add-ons are now obsolete, and whether by this you mean they should be deleted from the server or whether I should just "hide" them with a bronze quality rating but keep them available.

Top Quote
MarkMcWire
Avatar
Topic Opener
Joined: 2017-02-08, 21:06 UTC+1.0
Posts: 394
Ranking
Tribe Member
Location: Eisenach, Germany
Posted at: Yesterday 20:55 UTC+2.0

I've corrected that. BTW: Which is actually better in init.lua?

local dirname =

or just

dirname =

My widelands addons: https://drive.google.com/file/d/1jopANlODo41T2reHJ0zaCOMYxq_rxXP-/view?usp=sharing

Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2158
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: Yesterday 22:30 UTC+2.0

local dirname is better style since each value of dirname is intended just for the one file. But it does not matter much and I guess it is probably used inconsistently everywhere.

Top Quote
kaputtnik
Avatar
Joined: 2013-02-18, 20:48 UTC+1.0
Posts: 2674
OS: Archlinux
Version: current master
Ranking
One Elder of Players
Location: Germany
Posted at: Yesterday 23:15 UTC+2.0

It's just not better style, imho. Consider:

File init.lua:

dirname = "addons/some/folder"
include "addons/functions.lua"

File functions.lua

dirname = "addons/other/folder"

The value of dirname in init.lua will be overwritten with the value of functions.lua.

Using local dirname = in both files will prevent such overwriting. I think using local is best practice to prevent errors which are difficult to examine otherwise. And it does just not hurt face-wink.png

Top Quote
MarkMcWire
Avatar
Topic Opener
Joined: 2017-02-08, 21:06 UTC+1.0
Posts: 394
Ranking
Tribe Member
Location: Eisenach, Germany
Posted at: Yesterday 23:41 UTC+2.0

Okay, I've now changed it in all init.lua files for my two active add-ons. @Nordfriese europeans_tribe.wad and europeans_all.wad are the two active tribe add-ons that I'm still developing. The others are frozen.

Edited: Yesterday 23:41 UTC+2.0

My widelands addons: https://drive.google.com/file/d/1jopANlODo41T2reHJ0zaCOMYxq_rxXP-/view?usp=sharing

Top Quote