Topic: Adding updates to launchpad
Ex-Member
Topic Opener
Joined:
2014-09-12, 10:53 UTC+2.0
Posts: 184  Widelands-Forum-Junkie |
Posted at:
2017-11-15, 12:33 UTC+1.0
I think I have sorted out what I am doing with bazaar. As a test I have created an update to starting conditions which appears to be revision 8490. I have applied for membership of the dev team. I am now waiting approval and to see if my changes are acceptable. The starting conditions I have submitted are simple, a new starting condition for each tribe, I also have one for Frisians to either add later or add to the Frisians branch. My thought behind the new start is that the headquarters is most used but boring after a while, trading post and fortified village are to easy, both a sort of cheat mode. I have added a Village start that can be used on maps where the description says you have been living in the area for a while, you get a few basic buildings, nothing that needs thought on placing, to offset this you have lower military. The start condition has been tested on most maps with human and AI. 
Top
Quote
|
|
Tino
Joined:
2009-02-20, 17:05 UTC+1.0
Posts: 251  Tribe Member Location: Somewhere in Germany... |
Posted at:
2017-11-15, 13:33 UTC+1.0
Hi, you don't need to be a member of the widelands team to publish your code and make a merge request. Only if you want to be able to merge code to trunk directly or to publish branches owned by the team.
Top
Quote
|
|
Ex-Member
Topic Opener
Joined:
2014-09-12, 10:53 UTC+2.0
Posts: 184 Widelands-Forum-Junkie |
Posted at:
2017-11-15, 17:11 UTC+1.0
Well I created a branch and tried to push it but was told I could not as I was not a member of the dev team, My application was thrown out as I have not added any code, So how do I publish my contribution for approval?
Top
Quote
|
kaputtnik
Joined:
2013-02-18, 20:48 UTC+1.0
Posts: 2668 OS: Archlinux Version: current master  One Elder of Players Location: Germany |
Posted at:
2017-11-15, 17:49 UTC+1.0
Try this command (change 'YourUsername' with your Launchpad-ID). The BRANCHNAME is usually a short discription of the proposed change, eg. new_starting_conditions. bzr push lp:~YourUsername/widelands/BRANCHNAME After successful uploading the branch you can click on it and 'Propose for merging'.
Top
Quote
|
|
Ex-Member
Topic Opener
Joined:
2014-09-12, 10:53 UTC+2.0
Posts: 184 Widelands-Forum-Junkie |
Posted at:
2017-11-15, 22:55 UTC+1.0
That was what I tried, I get this error ssh_askpass: exec(/usr/lib/ssh/ssh-askpass): No such file or directory bzr: ERROR: Connection closed: Unexpected end of message. This looks like a permissions error although I have a registered key.
Top
Quote
|
GunChleoc
Joined:
2013-10-07, 15:56 UTC+2.0
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at:
2017-11-16, 07:49 UTC+1.0
Sorry, I hadn't seen this thread when I threw out your application, and your username at launchpad is radically different, so I had no idea it was you. You can still push though if you replace widelands-dev with ~username Have you registered an ssh key with Launchpad? https://help.launchpad.net/YourAccount/CreatingAnSSHKeyPair
Edited:
2017-11-16, 07:49 UTC+1.0
Busy indexing nil values
Top
Quote
|
|
Ex-Member
Topic Opener
Joined:
2014-09-12, 10:53 UTC+2.0
Posts: 184 Widelands-Forum-Junkie |
Posted at:
2017-11-16, 10:22 UTC+1.0
Ah username, I live in several different compartments and they are radically different, perhps I should have mentioned that. I got it to work today, perhaps hysterisis in the key system? In any case the branch is there and I have put it up for review. I have some more complex changes in the pipline now that I know how to upload.
Top
Quote
|
|
GunChleoc
Joined:
2013-10-07, 15:56 UTC+2.0
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at:
2017-11-17, 08:19 UTC+1.0
Thanks for the branch - I have left some comments in the code review. Busy indexing nil values
Top
Quote
|
|
Ex-Member
Topic Opener
Joined:
2014-09-12, 10:53 UTC+2.0
Posts: 184 Widelands-Forum-Junkie |
Posted at:
2017-11-17, 10:58 UTC+1.0
I took me a while to find out where the code review was, sorted now, and comments added.
Top
Quote
|