Topic: Hard coded weapons list. -> please remove

In the DefaultAI.h there is a hard-coded list of weapon names, which ensure that the AI sets the corresponding weapons in the training facilities to the value 1. This list is incomplete. Axes and spears are set to 1, but swords are not. This is particularly noticeable among the Europeans, as they use axes and swords as a type of weapon.

I suggest removing this static list or at least expanding it to include the Frisians and Amazons weapon types in order to avoid this inconsistent behavior.

	// this is a bunch of patterns that have to identify weapons and armors for input queues of
	// trainingsites
	std::vector<std::string> const armors_and_weapons = {
	   "ax", "armor", "helm", "lance", "trident", "tabard", "shield", "mask", "spear"};

My widelands addons: https://drive.google.com/file/d/1jopANlODo41T2reHJ0zaCOMYxq_rxXP-/view?usp=sharing

Top

Quote

> *Nordfriese wrote:*
>
> Known issue https://github.com/widelands/widelands/issues/3665

Okay, I can vaguely remember that we had this topic before.

I thought you had already adjusted it in build 22.

My widelands addons: https://drive.google.com/file/d/1jopANlODo41T2reHJ0zaCOMYxq_rxXP-/view?usp=sharing

Top

Quote

I am working on a general fix in https://github.com/gunchleoc/widelands/tree/ai-ware-categories

That branch is still in a very experimental stage though.

Busy indexing nil values

Top

Quote