Topic: Contributing
WorldSavior
Topic Opener
Joined:
2016-10-15, 04:10 UTC+2.0
Posts: 2146 OS: Linux Version: Recent tournament version  One Elder of Players Location: Germany |
Posted at:
2018-08-19, 20:08 UTC+2.0
Do we have further .lua-files which should be changed? And if we have them - is anyone here who would upload them to launchpad if I would send them? Wanted to save the world, then I got widetracked 
Top
Quote
|
GunChleoc
Joined:
2013-10-07, 15:56 UTC+2.0
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at:
2018-08-20, 09:49 UTC+2.0
I'd be happy to help with the upload again. The branch with your previous contribution is still being worked on: https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 @hessenfarmer, would you like to manage this? You know much more about the balancing stuff than I do. Busy indexing nil values
Top
Quote
|
|
WorldSavior
Topic Opener
Joined:
2016-10-15, 04:10 UTC+2.0
Posts: 2146 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at:
2018-08-20, 18:07 UTC+2.0
Ok
Could I help with reviewing there? Wanted to save the world, then I got widetracked
Top
Quote
|
hessenfarmer
Joined:
2014-12-11, 23:16 UTC+1.0
Posts: 2828 One Elder of Players Location: Bavaria |
Posted at:
2018-08-20, 21:33 UTC+2.0
Definitly some Review would help. Especially the fix for the Last comments would be helpful
Top
Quote
|
|
WorldSavior
Topic Opener
Joined:
2016-10-15, 04:10 UTC+2.0
Posts: 2146 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at:
2018-08-21, 01:22 UTC+2.0
How should I do that?
What is that exactly? Wanted to save the world, then I got widetracked
Top
Quote
|
|
GunChleoc
Joined:
2013-10-07, 15:56 UTC+2.0
Posts: 3317 One Elder of Players Location: RenderedRect |
Posted at:
2018-08-21, 09:31 UTC+2.0
You can do 2 things for reviewing:
Busy indexing nil values
Top
Quote
|
|
WorldSavior
Topic Opener
Joined:
2016-10-15, 04:10 UTC+2.0
Posts: 2146 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at:
2018-08-21, 14:45 UTC+2.0
Let's see if I can complete that task...
Isn't appveyor something which doesn't work with linux? And it wouldn't be enough to download the data-file and test via the datadir-command, right?
Edited:
2018-08-21, 14:47 UTC+2.0
Wanted to save the world, then I got widetracked
Top
Quote
|
|
hessenfarmer
Joined:
2014-12-11, 23:16 UTC+1.0
Posts: 2828 One Elder of Players Location: Bavaria |
Posted at:
2018-08-21, 15:22 UTC+2.0
Testing with datadir option should be possible. Only the fix regarding the behaviour of depleted mines would need a compiled version. As far as I know you can pull a branch via Bazaar without being logged in on launchpad. Compiling in linux is easy if you can get the source code. Appveyor just provides us with windows builds
Top
Quote
|
|
WorldSavior
Topic Opener
Joined:
2016-10-15, 04:10 UTC+2.0
Posts: 2146 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at:
2018-08-21, 22:18 UTC+2.0
Maybe it's easy for you, but not for me Wanted to save the world, then I got widetracked
Top
Quote
|
|
hessenfarmer
Joined:
2014-12-11, 23:16 UTC+1.0
Posts: 2828 One Elder of Players Location: Bavaria |
Posted at:
2018-08-22, 08:54 UTC+2.0
ok. I correct myself it is much easier than on windows. Perhaps you could try to follow this manual https://wl.widelands.org/wiki/Building%20Widelands/ and report if there isn't success.
Top
Quote
|
