Topic: Bugs between build20 and build21

Forums » Player Forums » Technical Help » Bugs between build20 and build21
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2137
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-04-14, 19:20 UTC+2.0

There was recently a build-21 map overhaul,

(It's still in progress, the PR is not merged yet)

now bugs.. Are there some decisions on build-21, or are we just becoming impatient?

There are currently 161 open issues and PRs targeted to b21 (https://github.com/widelands/widelands/milestone/1), so it's still some time off. However in my opinion there have been so many new features that IMHO we should consider making the release as soon as all the critical bugs are fixed (which will still take some time though).

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06 UTC+2.0
Posts: 206
Ranking
Widelands-Forum-Junkie
Location: Poland
Posted at: 2020-04-14, 19:39 UTC+2.0

Nordfriese wrote:

However in my opinion there have been so many new features that IMHO we should consider making the release as soon as all the critical bugs are fixed (which will still take some time though).

I agree.

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16 UTC+1.0
Posts: 2828
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2020-04-14, 20:34 UTC+2.0

WorldSavior wrote:

In the collectors mode, unexperienced players don't know what the match is about. Reason: There is no more message at the beginning of the match about the wares, it appears only after 60 minutes. There should be a message at the beginning of the match, but definitely no popup.

hessenfarmer wrote:

WorldSavior wrote:

Regression bug: Economy settings of Atlantean Blackroot Flour are missing, spotted in Amazons6762

they were removed due to being consistent with e.g. empire wine. see https://github.com/widelands/widelands/pull/3682

It's bad, because mills can waste time for superflouus black flower now. Imperial wine is a different story, because the whinery only produces one type of ware.

It should not waste time as it should only do blackrootflour if it is needed or no cornflour is needed. so if cornflour needed and no blackrootflour it will do blackroot.

Top Quote
kaputtnik
Avatar
Joined: 2013-02-18, 20:48 UTC+1.0
Posts: 2657
OS: Archlinux
Version: current master
Ranking
One Elder of Players
Location: Germany
Posted at: 2020-04-14, 20:35 UTC+2.0

Nordfriese wrote:

However in my opinion there have been so many new features that IMHO we should consider making the release as soon as all the critical bugs are fixed (which will still take some time though).

Yes, especially because some new features already introduced new bugs...

Some one should just declare the feature freeze... I'd vote for it face-smile.png

Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2137
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-04-14, 20:48 UTC+2.0

Way too soon now!! face-wink.png
There are a bunch of bugs in current master that could be real showstoppers, e.g. the shipping bugs I'm currently working on (yes the branch is still far from ready face-wink.png ). Also all PRs now open should be merged for b21.

But we could already go through the list of issues targeted to the active milestone and postpone all feature requests and minor bugs that don't urgently need to be taken care of for b21.
I'll open a b22-rc1 milestone for those, and create a label "Urgent" for all issues that really need to go into b21. (edit: done)

Edited: 2020-04-14, 20:51 UTC+2.0
Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2137
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-04-14, 21:30 UTC+2.0

I did some cleaning up on the milestone, now only 17 urgent bugs left of which 6 already have an open PR.
Of course any dev who wants to fix a retargeted issue for b21 is still welcome to do so face-smile.png

Edit: All bugs really intended to be fixed for b21 should be marked with the "urgent" label. Those targeted to b21 without this label haven't been decided on yet.

Edited: 2020-04-14, 21:32 UTC+2.0
Top Quote
simplypeachy

Joined: 2009-04-23, 12:42 UTC+2.0
Posts: 155
Ranking
At home in WL-forums
Location: Hampshire, UK
Posted at: 2020-04-15, 02:41 UTC+2.0

If any of the open PRs need testing I'm happy to give them a whirl.

WARNING: New-style view packet not found. There may be strange effects regarding unseen areas.
_aD on IRC

Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2137
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-04-15, 08:41 UTC+2.0

It would be good if you could test the tribes filtering branch: https://github.com/widelands/widelands/pull/3693
The PR has been open for two months now and nobody found time for it yet. If you test it, I'll do the code review and we might have it for b21.

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06 UTC+2.0
Posts: 206
Ranking
Widelands-Forum-Junkie
Location: Poland
Posted at: 2020-04-15, 14:50 UTC+2.0

I nominate these for "urgent":

Top Quote
Nordfriese
Avatar
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2137
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2020-04-15, 14:58 UTC+2.0

I am working on both in a branch that will also fix some other urgent shipping-related issues. But just to clarify I gave them (and another related issue) the urgent label now anyway.

Edited: 2020-04-15, 14:59 UTC+2.0
Top Quote