Latest Posts

Topic: Big upcoming string changes

GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2986
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2014-03-04, 10:24

We have a lot of game data errors, some of them localized, some of them not. Example:

throw game_data_error(_("building %1$u: %2$s"), serial, e.what());

throw game_data_error(_("flagdata: %s"), e.what());

Do we want to localize these or not? I guess this is info for the devs in case a bug comes up, so should these stay in English?

Edited: 2014-03-04, 10:25

Busy indexing nil values

Top Quote
Tino
Joined: 2009-02-20, 17:05
Posts: 251
Ranking
Tribe Member
Location: Somewhere in Germany...
Posted at: 2014-03-04, 11:47

Afaik the consensus was to not translate any log messages going to console, stdout or stderr. Looking at my last stdout.txt i can't find any german messages beside one (soundhandler "geschlossen" (closed)).

So my vote goes to not translate anything in the (err/std) logs and to remove any existing localization regarding this.

Edited: 2014-03-04, 11:47

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2986
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2014-03-04, 12:46

OK, I'll kick them out then face-smile.png


Busy indexing nil values

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2986
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2014-03-04, 13:24

Where does throw_warning end up, is that for the console/log files as well?


Busy indexing nil values

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2986
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2014-03-05, 10:32

I am looking for a string in-game.

../../src/logic/militarysite.cc:63

    m_workarea_info[m_conquer_radius].insert(descname() + _(" conquer"));

../../src/logic/warehouse.cc:266
    m_workarea_info[m_conquers].insert(descname() + _(" conquer"));

How do I get this on the screen, so I can find out how it is used/what it means?


Busy indexing nil values

Top Quote
MiroslavR
Joined: 2010-10-16, 17:56
Posts: 35
Ranking
Pry about Widelands
Location: Slovakia
Posted at: 2014-03-05, 12:03

Hey, Gun. Thanks for cleaning up all this mess. I especially appreciate some changes easing the pain of declension. However, there are still inconsistencies present, such as "fernery" (and "ferner") being the building where thatch reed is grown. Unfortunately, I don't really have anything to propose besides "reed farm", which is a bit dull. Also, I disagree with SirVer's decision to use American spelling for "axe". It may just be me, but I've never seen it spelt "ax" in texts that are supposed to be written in US English.


Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2986
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2014-03-05, 12:56

Actually, the "ax" was my decision. I think is looks weird too, but I'm more used to British spelling. In a googlefight, "ax" wins hands down, so I'm going to stay with it.

"reed farm" sounds too much like being a farm. This would hurt the orthogonality of game terms, because it's a medium sized building. What about reed yard or nursery?

"ferner" could be replaced by "gardener", does that sound like a good idea?


Busy indexing nil values

Top Quote
Tino
Joined: 2009-02-20, 17:05
Posts: 251
Ranking
Tribe Member
Location: Somewhere in Germany...
Posted at: 2014-03-05, 13:45

The strings in the sourcecode like _"ax" are only identifiers and should not be bound to a certain spelling in my opinion. The correct way would be to add "en_US" to our available localizations to handle the distinction to "en_GB".


Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2986
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2014-03-05, 14:34

I had a look at Launchpad and somebody is working on a translation for en_GB, so I figured we could have the original strings as default locale corresponding to American English. I could still undo this though if you think it's necessary.

BTW any thoughts on the meaning of _(" conquer")?

Edited: 2014-03-05, 14:35

Busy indexing nil values

Top Quote
SirVer
Joined: 2009-02-19, 15:18
Posts: 1439
Ranking
One Elder of Players
Location: Germany - Munich
Posted at: 2014-03-05, 18:37

I have no feeling for english, but I'd like to have consistency. I think most of the game lends towards american english, so I think being consistent there is a good choice. I think Reed Yard sounds nice too. The one thing that still bothers me is 'trunk' which should probably be log (do native speakers agree?).

I also think that we can make these changes one by one in trunk - no need to do it all right now. As long as it is done before b19 - till then I do not care about safe game compatibility, so we can change stuff around as we ilke.


Top Quote