Topic: Frisians 02 crash when red HQ destroyed before storehouse full

I think the crash is caused by the script in mission_thread.lua not checking if the player 2 HQ is still around here. How can I change it so that it checks first and then fails gracefully instead of crashing the game? Maybe there needs to be a function that checks if the red player HQ has been destroyed by the yellows before the human player has the all items in the empire warehouse?

---

Attachment: image/png

Top

Quote

Thanks for the tip kaputtnik but since hq is a local variable which is an array of empire_headquarters from p2:get_buildings, and the game crashes trying to set that variable, it will crash before .exists can work. What I may try is to do something like

    if check_for_buildings(p2,{empire_headquarters = 1,}) then
        local hq = p2:get_buildings("empire_headquarters")[1]

and carry on the script part that transfers wares, so if p2 does not have any empire_headquarters it will just skip the whole wares transfer part.

Top

Quote

or get the array and check if it is empty:

local hq = p2:get_buildings("empire_heaquarters")
if #hq > 0:                       -- may be if #hq is enough, my brain is currently on python syntax…
    hq = hq[1]

or iterate over the array?

local hq = Nil
for building in p2:get_buildings("empire_heaquarters") do
     if building then
          hq = building

Top

Quote

well, that is surprising to me as well as this has never happened in testplay to me.
However, I think the fundamental question is whether the Barbarians shuld be allowed to win over the empire.
If yes we might need a different ongoing of the story like we were lucky to get rid of the empire by a foreign tribe, but they are hostile tous as well sowe need to finish them as well to male the island ours.
Or we need to take care that this can't happen by forbid fighting between them until several conditions have been met.

Personally I tend to like option 1 a bit more, but it is a lot of additional work on the story.

Top

Quote

hessenfarmer wrote

well, that is surprising to me as well as this has never happened in testplay to me.
However, I think the fundamental question is whether the Barbarians shuld be allowed to win over the empire.
If yes we might need a different ongoing of the story like we were lucky to get rid of the empire by a foreign tribe, but they are hostile tous as well sowe need to finish them as well to male the island ours.
Or we need to take care that this can't happen by forbid fighting between them until several conditions have been met.

Personally I tend to like option 1 a bit more, but it is a lot of additional work on the story.

The story could be that the Barbarians say the player should instead pay them for liberating them from the Roman yoke of oppression and they then impose their own bribe conditions and take the stuff in the warehouse if it contains what they want. The player has probably not been able to train their soldiers because they have been trying to micromanage the economy for the Roman warehouse, so this may give them some time to train up before the Barbarians finally attack.

Alternatively the story could be that some escaping Romans bring word that the Barbarians have caused the fall of their empire and can give the player some gold or swords or something saying to use them to avenge them by defeating the Barbarians.

Top

Quote