Latest Posts

Topic: Release 1.2

Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2054
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-05-01, 14:14

Since there have been a number of bug and crash reports with v1.2, we are planning to make a point release 1.2.1 which will backport several bugfixes. The release-1.2 git branch has been updated with the following changes:

  • c51189f67aa06b2273486134473f17c7a014ace8 (Skip invalid map files in editor Load/Save map window)
  • b0c4c025befe3c3c09226b52cdd5d41446ffe16b (Fix memory leaks in main menu Watch Last Replay)
  • b166b0b52a7da5dc88c74b079149cc46e806de81 (Game setup: Unselect incompatible starting conditions when changing win condition)
  • 1907f67c6978b4dc8717e0c84670727940eea80b (Fix soldier request for expedition ships)
  • 1babc3aac05757ac25c6992da13afa6c41a6cec5 (Add thread identifier to crash reports)
  • 145b2ab5d9137fe572f0c7500cbd7cff34c292a0 (Check for invalid combination before calling DefaultAI::expedition_management())

I would like to publish the release candidate on TBA and the point release on TBA.

Since this is just a point release with a small number of smallish bugfixes, this schedule is not quite so important. If there are any other major bugs in v1.2 that you would deem worth backporting, assuming they can be fixed soon and without massive codechanges, please post them and we can wait with the point release. Lots of testing of the release branch will also be appreciated face-smile.png

Edited: 2024-05-01, 17:22

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2734
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2024-05-01, 15:35

Nordfriese wrote:

Since there have been a number of bug and crash reports with v1.2, we are planning to make a point release 1.2.1 which will backport several bugfixes. The release-1.2 git branch has been updated with the following changes:

  • c51189f67aa06b2273486134473f17c7a014ace8 (Skip invalid map files in editor Load/Save map window)
  • b0c4c025befe3c3c09226b52cdd5d41446ffe16b (Fix memory leaks in main menu Watch Last Replay)
  • b166b0b52a7da5dc88c74b079149cc46e806de81 (Game setup: Unselect incompatible starting conditions when changing win condition)
  • 1907f67c6978b4dc8717e0c84670727940eea80b (Fix soldier request for expedition ships)
  • 1babc3aac05757ac25c6992da13afa6c41a6cec5 (Add thread identifier to crash reports)
  • 145b2ab5d9137fe572f0c7500cbd7cff34c292a0 (Check for invalid combination before calling DefaultAI::expedition_management())

I would like to publish the release candidate on Saturday May 4th 2024 and the point release on Saturday May 11th 2024.

Since this is just a point release with a small number of smallish bugfixes, this schedule is short-notice and not quite so important. If there are any other major bugs in v1.2 that you would deem worth backporting, assuming they can be fixed soon and without massive codechanges, please post them and we can wait with the point release. Lots of testing of the release branch will also be appreciated face-smile.png

well at least I'd like to have https://codeberg.org/wl/widelands/commit/1f0dc4c387aa7247dd69b49a074e79446612df1c as well, for ethical reasons.


Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2054
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-05-01, 17:24

Good point will add that one too.

On second thoughts maybe we should remove 1907f67c6978b4dc8717e0c84670727940eea80b (Fix soldier request for expedition ships) again? It's the only one on the list with game mechanic changes, so if we drop it from the point release we could maintain full multiplayer compatibility between 1.2 and 1.2.1.

I removed the dates from the post above again…
Milestone: https://codeberg.org/wl/widelands/milestone/6255


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2734
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2024-05-01, 20:25

Nordfriese wrote:

Good point will add that one too.

On second thoughts maybe we should remove 1907f67c6978b4dc8717e0c84670727940eea80b (Fix soldier request for expedition ships) again? It's the only one on the list with game mechanic changes, so if we drop it from the point release we could maintain full multiplayer compatibility between 1.2 and 1.2.1.

+1 for just fixing bugs and not change game mechanics if possible.

I removed the dates from the post above again…
Milestone: https://codeberg.org/wl/widelands/milestone/6255


Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2054
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-10-30, 14:56

Well, almost half a year after making the decision the release candidate is out face-smile.png

https://codeberg.org/wl/widelands/releases/tag/v1.2.1-rc1

I'm planning the final point release for next Thursday, the 7th of November, 2024.

Please report any major bugs you find with the point release.

Edited: 2024-10-30, 14:57

Top Quote
tothxa
Avatar
Joined: 2021-03-24, 12:44
Posts: 482
OS: antix / Debian
Version: some new PR I'm testing
Ranking
Tribe Member
Posted at: 2024-10-31, 01:34

The RC is up on flathub-beta too.


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2734
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2024-11-02, 00:08

we have a reproducable bug in the windows 32 bit version that is really annoying.
so from my perspective we have the following options if this can't be addressed soon.

  1. skip the 32 bit windows build completely, as MINGW is dropping 32 bit support as well.
  2. do nothing and hope there are only a few users using the 32 bit version. (this might be used as indicator whehter there are still a relevant number of 32 bit users

Top Quote
tothxa
Avatar
Joined: 2021-03-24, 12:44
Posts: 482
OS: antix / Debian
Version: some new PR I'm testing
Ranking
Tribe Member
Posted at: 2024-11-02, 00:58

hessenfarmer wrote:

we have a reproducable bug in the windows 32 bit version that is really annoying.

Is this new to 1.2.1rc1, or also affects v1.2?


Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2054
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-11-02, 09:44

Well, Naval Warfare is marked as Experimental and disabled-by-default in 1.2 and also 1.2.1. It would still be good to get backtrace and a way to fix this, but IMO this is not a blocker and we could release 1.2.1 with this bug if we don't figure out the root cause in time.


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2734
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2024-11-02, 10:21

getting a backtrace was not possible as the crash of the game was catched by our framework, which provided a error message.
or at least I do not know how to get a backtrace in this case with gdb.
when I got back to gdp the stack was empty


Top Quote