Topic: AI hints cause the game to crash. -> fixing code

If several buildings have the hint "supports_production_of = {" log "}," or "collects_ware_from_map =" log "," the game crashes. I noticed that because I built two extensions for all building types, including for the foresters and lumberjacks. If I also give this AI Hint to the expanded buildings, I can no longer start the game.

The same applies to fisher houses, hunting houses and wells. Strangely enough, that doesn't happen to mines, fish breeders houses or gamekeepers houses.

Edit, I found the code in the defaultai.cc, that throws these exceptions.

// We must verify that some buildings has been identified
	// Also note that the AI assumes that some buildings are unique, if you want to
	// create e.g. two barracks or bakeries, the impact on the AI must be considered
	if (count_buildings_with_attribute(BuildingAttribute::kBarracks) != 1) {
		throw wexception("The AI needs the tribe '%s' to define 1 type of barracks building. "
		                 "This is the building that produces the tribe's 'soldier' worker.",
		                 tribe_->name().c_str());
	}
	if (count_buildings_with_attribute(BuildingAttribute::kRanger) != 1) {
		throw wexception(
		   "The AI needs the tribe '%s' to define 1 type of ranger's building. "
		   "This is the building that has 'supports_production_of = { \"log\" }' in its AI hints.",
		   tribe_->name().c_str());
	}
	if (count_buildings_with_attribute(BuildingAttribute::kWell) != 1) {
		throw wexception(
		   "The AI needs the tribe '%s' to define 1 type of well. "
		   "This is the building that has 'collects_ware_from_map = \"water\"' in its AI hints.",
		   tribe_->name().c_str());
	}
	if (count_buildings_with_attribute(BuildingAttribute::kLumberjack) != 1) {
		throw wexception(
		   "The AI needs the tribe '%s' to define 1 type of lumberjack's building. "
		   "This is the building that has 'collects_ware_from_map = \"log\"' in its AI hints.",
		   tribe_->name().c_str());
	}

	if (count_buildings_with_attribute(BuildingAttribute::kHunter) != 0 &&
	    count_buildings_with_attribute(BuildingAttribute::kHunter) != 1) {
		throw wexception(
		   "The AI needs the tribe '%s' to define 1 type of hunter's building at the most. "
		   "Hunters are buildings that have 'collects_ware_from_map = \"meat\"' in their AI hints.",
		   tribe_->name().c_str());
	}

	if (count_buildings_with_attribute(BuildingAttribute::kFisher) != 1) {
		throw wexception(
		   "The AI needs the tribe '%s' to define 1 type of fisher's building. "
		   "This is the building that has 'collects_ware_from_map = \"fish\"' in its AI hints "
		   "and doesn't have any ware inputs.",
		   tribe_->name().c_str());
	}

My widelands addons: https://drive.google.com/file/d/1jopANlODo41T2reHJ0zaCOMYxq_rxXP-/view?usp=sharing

Top

Quote

The historical reason for this was that AI decides to have (for example) 5 wood cutters, 2 hunters, 4 wells - and it is simpler if there is only one type of cutter, one type of well and so on. If we allow multiple buildings of the same type - I dont know how ready AI is for it.

Top

Quote

But some assertions fail....

Top

Quote

I mean they have some reason to be there. The fact that game does not crash after removing some of them does not mean that no harm was done.

Top

Quote