Latest Posts

Topic: savegane backward compatibility?

jmoerschbach
Avatar
Joined: 2019-09-26, 21:40
Posts: 2
Ranking
Just found this site
Posted at: 2019-09-26, 21:47

Hi,

after filing in my very first bug on github, I just registered on the forum since I like to join your community and hopefully, I can contribute in some ways in near future face-smile.png

Before I file the next bug, I thought maybe I'll ask before...

I've started playing campaigns with official build 20 release.

When I load a savegame (first atlanteans mission) in self-compiled trunk version, I'll get an error saying buildingdata: building 1818519809: not found

So I guess my savegame from b20 is not compatible with trunk version. Is this accepted/intentional or am I doing something wrong?

If it is considered a bug, I'll file an issue with savegame, screenshot etc... face-wink.png

Regards,

Jonas


Top Quote
einstein13
Avatar
Joined: 2013-07-29, 00:01
Posts: 1088
Ranking
One Elder of Players
Location: Poland
Posted at: 2019-09-27, 09:44

Hi and welcome to the forum!

Save games are intended to be version-specific. Usually you can open the file with trunk version of Widelands +/- a few commits. The same is when you try to play a multiplayer game. If you try to play a game with someone who doesn't have the same Widelands version, the game can desynchronises pretty soon (or you will not able to connect).

As far as I know only maps are designed to have backward compatibility. But even this is broken somewhere in the past: you can download very old maps from "The Game -> Maps" section and not be able to open them with the editor.


einstein13
calculations & maps packages: http://wuatek.no-ip.org/~rak/widelands/

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3057
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2019-09-27, 09:54

We are trying to keep savegame compatibility too as much as we can. There's a change that broke it and we haven't had time to track down the commit that broke it yet.


Busy indexing nil values

Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 1257
Ranking
One Elder of Players
Location: GER
Posted at: 2019-09-27, 17:44

einstein13 wrote:

Usually you can open the file with trunk version of Widelands +/- a few commits.

I disagree. Usually "few commits" is not true but "a lot of commits" - breaking of savegame compability is rather rare.

GunChleoc wrote:

We are trying to keep savegame compatibility too as much as we can. There's a change that broke it and we haven't had time to track down the commit that broke it yet.

I see it between 9182 and 9203.


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3057
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2019-09-27, 18:21

Thanks for narrowing it down face-smile.png


Busy indexing nil values

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 31
Ranking
Pry about Widelands
Posted at: 2019-09-27, 18:48

GunChleoc wrote:

We are trying to keep savegame compatibility too as much as we can. There's a change that broke it and we haven't had time to track down the commit that broke it yet.

You mean the one that made Build 20 savegames unloadable with later versions?


Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3057
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2019-09-27, 19:18

Looks like the culprit is this one:

https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/9107

It does contain compatibility code, but it contains a mistake that is so duh that I'll push a fix directly to master. The things one does not see during code review...

And welcome aboard! face-smile.png

Edited: 2019-09-27, 19:27

Busy indexing nil values

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 31
Ranking
Pry about Widelands
Posted at: 2019-09-27, 21:30

There's at least one more problem with loading Build 20 saves. Trying to load the attached savegame results in the following error:

Game data error
buildings: unknown ware type "thatch_reed"

Likely related to the following commits:

777771e9ed Renamed thatch reed to reed.

c7e8e09267 Fix savegame compatibility for reed, buildings, players view and economy requests.


Attachment: 215.wgf (626.3 KB)

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 3057
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2019-09-28, 01:08

Confirmed. I'm a bit pressed for time right now, could you please open an issue on GitHub? Thanks! face-smile.png


Busy indexing nil values

Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 31
Ranking
Pry about Widelands
Posted at: 2019-09-28, 02:20

Issue: Can't load Build 20 save: unknown ware type "thatch_reed" #3529


Top Quote