Topic: main roads becoming normal again
|
Tibor
Joined: 2009-03-23, 22:24
Posts: 1377  One Elder of Players Location: Slovakia |
Posted at: 2018-05-10, 20:30
Updated and uploaded. Works ... 
Top
Quote
|
ypopezios
Joined: 2018-04-19, 23:22
Posts: 220  Widelands-Forum-Junkie |
Posted at: 2018-05-14, 00:15
This time I also played whole scenarios to see promotions/demotions in real conditions. They both work as expected and much better than the old algorithm. No issue found. The code is ready for review and merge, and it is safe even for build 20. That frees me to contribute in other things. I'm open to suggestions. I'm generally more interested in algorithms (promotion/demotion has been a good example). Suggestions from Tibor get priority, for obvious reasons.
Top
Quote
|
GunChleoc
Joined: 2013-10-07, 14:56
Posts: 3324 One Elder of Players Location: RenderedRect |
Posted at: 2018-05-14, 06:58
Maybe you could work together with Einstein on this one: https://wl.widelands.org/forum/topic/4245/?page=3#post-24907 Busy indexing nil values
Top
Quote
|
einstein13
Joined: 2013-07-28, 23:01
Posts: 1118 One Elder of Players Location: Poland |
Posted at: 2018-05-14, 06:58
@ypopezios From my point of view it is a huge part of work. First some finding out how current system works, then stick to the architecture or develop brand new one. And finally find proper algorithm that will help Widelands working smoothly. einstein13
Top
Quote
|
|
Tibor
Joined: 2009-03-23, 22:24
Posts: 1377 One Elder of Players Location: Slovakia |
Posted at: 2018-05-14, 07:13
@ypopezios You can start wit installing Linux so you can compile the game by yourselves
Top
Quote
|
|
einstein13
Joined: 2013-07-28, 23:01
Posts: 1118 One Elder of Players Location: Poland |
Posted at: 2018-05-14, 07:59
You don't have to install it on the whole machine. I use virtualization. It is enough for Widelands and many more einstein13
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 14:56
Posts: 3324 One Elder of Players Location: RenderedRect |
Posted at: 2018-05-14, 09:03
I use VMWare with Linux Mint, which is even more Windows-like. If you don't want to bother with a compiling environment, just get Bazaar so that you can create branches, and start a merge request. This will trigger AppVeyor builds that you can run on Windows. For finding interesting problems, try the economy tag Edited: 2018-05-14, 09:04
Busy indexing nil values
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 14:56
Posts: 3324 One Elder of Players Location: RenderedRect |
Posted at: 2018-05-15, 05:49
I have done a code review. Please check carefully that I haven't accidentally changed the semantics of the algorithm. There is also a NOCOM question in there that needs resolving. I ran a small test scenario where I emptied out a warehouse to create some busy roads, then sent wares over one of them afterwards. In trunk, no roads were demoted. In this branch, the road that I sent wares across was eventually demoted. Unused roads are never demoted in either version, but I guess that's a problem for another day? Busy indexing nil values
Top
Quote
|
|
Tibor
Joined: 2009-03-23, 22:24
Posts: 1377 One Elder of Players Location: Slovakia |
Posted at: 2018-05-15, 06:48
I dont think it is a problem, it is a nice feature by my opinion...
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 14:56
Posts: 3324 One Elder of Players Location: RenderedRect |
Posted at: 2018-05-15, 07:02
Why do you think that it's a nice feature? I'm not seeing the advantage right now, because the carrier2 should be more useful in a road that's actually being used. Or am I overlooking something? Busy indexing nil values
Top
Quote
|
. You can try Ubuntu. It is very Windows-users-friendly, but still it is Linux.