Currently Online

Latest Posts

Topic: Krater Bug

Tibor

Joined: 2009-03-23, 23:24
Posts: 1377
Ranking
One Elder of Players
Location: Slovakia
Posted at: 2020-08-23, 11:36

Those replays does not work - they are just short or desync immediately....


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2646
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2020-08-23, 11:56

Tibor wrote:

Those replays does not work - they are just short or desync immediately....

well they worked with b21 for me


Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 206
Ranking
Widelands-Forum-Junkie
Location: Poland
Posted at: 2020-08-23, 12:12

Two of them work fine for me with Build 21. I can't find the version for the third one.


Top Quote
Tibor

Joined: 2009-03-23, 23:24
Posts: 1377
Ranking
One Elder of Players
Location: Slovakia
Posted at: 2020-08-23, 12:14

Correct - they work with b21. It seems shipyards are built after reaching the basic economy. But this is all what we can find out from this. Is it possible to stop replay and start playing from that point? probably not....


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2646
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2020-08-23, 12:42

indeed it is possible. tried this out with the desert tournament replay and neither of the AI built a shipyard in this game. So I strongly believe it is something in the installation of @_Elefantenrennen.

@_Elefantenrennen could you please try to reproduce this in a new clean installation of b21. Especially the data directory should be deleted. btw. did you make any changes in there?


Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 206
Ranking
Widelands-Forum-Junkie
Location: Poland
Posted at: 2020-08-23, 13:15

Building disabled buildings should probably be made an illegal command. So even if the AI attempts it it shouldn't be accepted by the engine.


Top Quote
Tibor

Joined: 2009-03-23, 23:24
Posts: 1377
Ranking
One Elder of Players
Location: Slovakia
Posted at: 2020-08-23, 13:51

Perhaps but in production builds only. But generally it would only hide errors in AI and this would be bad...


Top Quote
niektory
Avatar
Joined: 2019-06-03, 20:06
Posts: 206
Ranking
Widelands-Forum-Junkie
Location: Poland
Posted at: 2020-08-23, 14:52

Tibor wrote:

But generally it would only hide errors in AI and this would be bad...

On the contrary I think. If a command is recognized as illegal it can be logged, throw an error or be handled in another way. If it is not recognized it will just be accepted and result in incorrect behavior that might or might not be noticed.


Top Quote
Tibor

Joined: 2009-03-23, 23:24
Posts: 1377
Ranking
One Elder of Players
Location: Slovakia
Posted at: 2020-08-23, 14:59

OK, on development build it would crash the game - just like asserts we are using now...
On production build it can ignore the command...


Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 2646
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2020-08-23, 15:47

niektory wrote:

Building disabled buildings should probably be made an illegal command. So even if the AI attempts it it shouldn't be accepted by the engine.

In principle this might be a good idea. However in this special case this wouldn't help as most obviously the detection of the buuiding being disabled failed. I more and more believe this is not a bug in our code but an issue in the installation of the user. (e.g. a data dir with relicts of older versions or something similar)


Top Quote