Topic: main roads becoming normal again
GunChleoc |
Posted at: 2018-05-25, 18:42
Glad to hear that you can compile yourself now I agree that having your branch for Build 20 is viable once we have fixed the linker error. I have run out of time though, so I won't be able to work on this before August. My virtual machine that I'll take with me is too slow for debug builds. We also still have a bunch of commented out code in it that should be deleted if you don't need it anymore to work on the algorithm. Busy indexing nil values Top Quote |
ypopezios |
Posted at: 2018-05-26, 00:11
@GunChleoc Feel free to delete the commented-out lines. They are not part of the algorithm and they probably don't even serve as placeholders. The linker error will disappear if you split again the constants, like Tibor had them. Top Quote |
GunChleoc |
Posted at: 2018-05-26, 08:41
I can squeeze this in today, so I'm on it. It's really weird, because it does fine the kAnimalPrice a few lines above. I have included road.h in test_routing.cc to see if that makes any difference. I'm not familiar with how boost test cases work, so fingers crossed. Another question: how much of the log output do we still need? Edited: 2018-05-26, 08:41
Busy indexing nil values Top Quote |
ypopezios |
Posted at: 2018-05-26, 09:46
We need none of it. The wallet value provided in the debug window (i.e. log_general_info) should be enough. We could consider adding more info there, but it's optional. Top Quote |
GunChleoc |
Posted at: 2018-05-26, 13:22
I found the bug - the branch is ready for final review Edited: 2018-05-26, 13:22
Busy indexing nil values Top Quote |
ypopezios |
Posted at: 2018-05-26, 14:43
As far as I'm concerned, all is well except of file tribes/carrier.cc :
Top Quote |
GunChleoc |
Posted at: 2018-05-26, 17:37
Done. Busy indexing nil values Top Quote |
ypopezios |
Posted at: 2018-05-26, 18:24
Well done! Seems that we can communicate after all... Top Quote |
GunChleoc |
Posted at: 2018-05-26, 18:30
Yes, much better now Busy indexing nil values Top Quote |
ypopezios |
Posted at: 2018-05-29, 22:06
@GunChleoc Concerning demotion of fully idle roads, a quick fix would be to replace line 108 of file tribes/carrier.cc with this:
Top Quote |